Skip to content

Prevent inlining of zend_compile_expr_inner() to guarantee low stack usage of compilation #23294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kubawerlos wants to merge 2 commits into
base: master
Choose a base branch
from
+3 −1
Open

Prevent inlining of zend_compile_expr_inner() to guarantee low stack usage of compilation #23294

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f5b0cd
Add test
kubawerlos Aug 15, 2026
3f7ca4c
Prevent inlining of `zend_compile_expr_inner()` to guarantee low stac…
kubawerlos Aug 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Zend/zend_compile.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12439,7 +12439,9 @@ static void zend_compile_stmt(zend_ast *ast) /* {{{ */
}
/* }}} */

static void zend_compile_expr_inner(znode *result, zend_ast *ast) /* {{{ */
/* Keep this out of zend_compile_expr(): the two form a recursion cycle, so inlining merges this
* frame into every nesting level of an expression, tripling the stack needed to compile it. */
static zend_never_inline void zend_compile_expr_inner(znode *result, zend_ast *ast) /* {{{ */
{
/* CG(zend_lineno) = ast->lineno; */
CG(zend_lineno) = zend_ast_get_lineno(ast);
Expand Down
Loading