Zend: Various refactor with zend_hash_str_find_ptr_lc - #23293
Open
LamentXU123 wants to merge 1 commit into
Open
Conversation
Girgias
approved these changes
Aug 15, 2026
Girgias
left a comment
Member
There was a problem hiding this comment.
I'm surprised that PHP extensions are case insensitive, but the change makes sense.
Member
|
one nice follow-up, if that makes sense, would be to update ini_get_all() lookup then ? |
Member
Author
Yes, ini_get_all("Pcre") now returns False. But would this requires a RFC or a email to the list? |
Member
|
there are probably more things to unpack and update than just this change now thinking of it, so yes at least an email. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zend_hash_str_find_ptr_lcis very useful in place we need to deal with lower case strings. Here we use it to replace the process of first creating the string, turn it to lower case and free it.