Skip to content

Fix GH-7781: CLI server prints HTML in startup warnings #23269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matthiasgoergens wants to merge 1 commit into
base: master
Choose a base branch
from
+43 −1
Open

Fix GH-7781: CLI server prints HTML in startup warnings #23269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions NEWS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@ PHP NEWS
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
?? ??? ????, PHP 8.6.0beta1

- CLI:
. Fixed bug GH-7781 (Built-in web server prints HTML in startup warnings).
(Matthias Görgens)

- GMP:
. Added optional $definitely_prime output parameter to gmp_prevprime().
(Weilin Du)
Expand Down
9 changes: 8 additions & 1 deletion sapi/cli/php_cli_server.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2797,6 +2797,8 @@ int do_cli_server(int argc, char **argv) /* {{{ */
char *php_optarg = NULL;
int php_optind = 1;
int c, r;
bool html_errors;
zend_result server_ctor_result;
const char *server_bind_address = NULL;
extern const opt_struct OPTIONS[];
const char *document_root = NULL;
Expand Down Expand Up @@ -2868,7 +2870,12 @@ int do_cli_server(int argc, char **argv) /* {{{ */
router = argv[php_optind];
}

if (FAILURE == php_cli_server_ctor(&server, server_bind_address, document_root, router)) {
/* Startup diagnostics are written to a terminal, not an HTTP response. */
html_errors = PG(html_errors);

@devnexen devnexen Aug 14, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not acting on display_errors instead ? e.g.

     ...
     uint8_t display_errors = PG(display_errors);
     PG(display_errors) = 0;
     /// note: php_cli_server_ctor() reports its own failures through php_cli_server_logf()
     server_ctor_result = php_cli_server_ctor(&server, server_bind_address, document_root, router);
     PG(display_errors) = display_errors;
     ...

PG(html_errors) = false;
server_ctor_result = php_cli_server_ctor(&server, server_bind_address, document_root, router);
PG(html_errors) = html_errors;
if (FAILURE == server_ctor_result) {
return 1;
}
sapi_module.phpinfo_as_text = 0;
Expand Down
31 changes: 31 additions & 0 deletions sapi/cli/tests/gh7781.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
--TEST--
GH-7781 (Built-in server startup warnings should not contain HTML)
--FILE--
<?php
$process = proc_open(
[PHP_BINARY, '-n', '-S', '0.0..0:8080'],
[
['pipe', 'r'],
['pipe', 'w'],
['pipe', 'w'],
],
$pipes,
);

fclose($pipes[0]);
$stdout = stream_get_contents($pipes[1]);
$stderr = stream_get_contents($pipes[2]);
fclose($pipes[1]);
fclose($pipes[2]);
$status = proc_close($process);

var_dump($status);
var_dump(str_contains($stdout, '<br'));
var_dump(str_contains($stdout, 'Warning: Unknown: php_network_getaddresses:'));
var_dump(str_contains($stderr, 'Failed to listen on 0.0..0:8080'));
?>
--EXPECT--
int(1)
bool(false)
bool(true)
bool(true)
Loading