Fix DOMXPath crash wrapping a foreign node after a nodeset callback - #23253
Open
iliaal wants to merge 1 commit into
Open
Fix DOMXPath crash wrapping a foreign node after a nodeset callback#23253iliaal wants to merge 1 commit into
iliaal wants to merge 1 commit into
Conversation
dom_xpath_intern_for_doc walked xpath_callbacks.node_list with Z_DOMOBJ_P on every entry. That list also stores arrays (nodeset-mode callback arguments). Same-document results take the early return; a later php:function that returns a node from another document walks the leftover array first. Skip non-objects and recurse into arrays so the matching intern is found instead of type-confusing the array.
devnexen
reviewed
Aug 14, 2026
| ZEND_HASH_PACKED_FOREACH_VAL(node_list, entry) { | ||
| dom_object *obj = Z_DOMOBJ_P(entry); | ||
| if (obj->document && obj->document->ptr == doc) { | ||
| ZEND_HASH_FOREACH_VAL(node_list, entry) { |
Member
There was a problem hiding this comment.
what s the reason of this change?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xpath_callbacks.node_list stores both DOM objects and arrays (nodeset-mode php:function args). dom_xpath_intern_for_doc did Z_DOMOBJ_P on every entry. Same-document results take the early return; a later callback that returns a node from another document walks leftover arrays first. This skips non-objects and recurses into arrays. PHP-8.5 is the lowest branch with intern_for_doc.