Fix leak when persistent PDO liveness check fails - #23249
Open
iliaal wants to merge 1 commit into
Open
Conversation
zend_list_close() only runs list_dtor_ex, which is NULL for PDO, so a dead cached handle with refcount 1 was evicted and never freed. Delete the persistent_list entry so php_pdo_pdbh_dtor runs. Live handles (refcount > 1) still evict without freeing.
| echo $next->query('SELECT 1')->fetchColumn(), "\n"; | ||
| ?> | ||
| --EXPECT-- | ||
| 1 |
Member
There was a problem hiding this comment.
So how does this test check for the leak?
Contributor
Author
There was a problem hiding this comment.
It triggers the dead-handle reconnect. The leaked handle is pecalloc, so you only see it under valgrind or LSAN, not in --EXPECT--.
Member
There was a problem hiding this comment.
Does it depend on some configuration data?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zend_list_close() only runs PDO's regular resource dtor, which is NULL. A dead cached persistent handle with no other live PDO object was dropped from the cache and never passed to php_pdo_pdbh_dtor. Delete the persistent_list entry so the persistent dtor runs. If another PDO object still holds the handle, the cache entry is only evicted.