Fix DOMNameSpaceNode clone UAF after xinclude - #23248
Open
iliaal wants to merge 1 commit into
Open
Conversation
Clone built the fake namespace decl from original_node->parent. After xinclude that parent is gone; parent_intern is the durable handle. lookupNamespaceURI and parentNode still use original_node->parent (open PR 22627).
devnexen
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DOMNameSpaceNode clone used original_node->parent to build the fake namespace decl. After DOMDocument::xinclude() that parent is freed. The clone now takes its parent from parent_intern, or NULL if that wrapper was stripped. parentNode and lookup* still use original_node->parent (#22627).