Fix GH-23244: sync PHP 8.4 m4 file with 8.5 - #23247
Open
LamentXU123 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP 8.4 still used the older manual LDAP library detection when
--with-ldapwas passed without an explicit directory, which cause GH-23244 that only occurs on 8.4.In 8.5 since 3677871, we've implement a better configure logic, here we can directly sync the 8.5 .m4 file to 8.4 to fix the bug (without deprecations that only affects 8.5+).
This cherry-picked:
3677871
Use pkg-config for ext/ldap without a directory (#17441)
25e8aa5
Autotools: Fix ext/ldap shared build (#18673)
840dc19
fix ldap.h detection without pkgconfig (#19005)