tree-wide: Refactor with zend_string_ends_with* - #23216
Open
LamentXU123 wants to merge 1 commit into
Open
Conversation
LamentXU123
requested review from
Girgias,
NattyNarwhal,
bukka,
devnexen,
dstogov and
jorgsowa
as code owners
August 11, 2026 12:03
jorgsowa
approved these changes
Aug 11, 2026
jorgsowa
left a comment
Contributor
There was a problem hiding this comment.
Looks good for ext/session
devnexen
approved these changes
Aug 11, 2026
Girgias
requested changes
Aug 11, 2026
Comment on lines
+1522
to
+1523
| return filename && ZSTR_LEN(filename) > sizeof(".phar") - 1 && | ||
| zend_string_ends_with_literal(filename, ".phar") && |
Member
There was a problem hiding this comment.
You no longer need the ZSTR_LEN comparison, as that's taken care of by zend_string_ends_with_literal
|
|
||
| int result; | ||
| if (ZSTR_LEN(tmp) > 0 && ZSTR_VAL(tmp)[ZSTR_LEN(tmp) - 1] != '\n') { | ||
| if (ZSTR_LEN(tmp) > 0 && !zend_string_ends_with_literal(tmp, "\n")) { |
| } else { | ||
| return false; | ||
| } | ||
| return ZSTR_LEN(host) > ZSTR_LEN(domain) && zend_string_ends_with(host, domain); |
| } | ||
|
|
||
| bool empty = ZSTR_VAL(buf->s)[ZSTR_LEN(buf->s) - 1] != ','; | ||
| bool empty = !zend_string_ends_with_literal(buf->s, ","); |
Member
There was a problem hiding this comment.
Are these calls inlined? As this might have a performance impact? (Mainly asking as I know some work was done to improve the performance of the encoder recently)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Utilize
zend_string_ends_with*APIs added in #22819.