zend_objects_API: Assert that the .offset is correct in zend_object_alloc() - #23101
Draft
TimWolla wants to merge 2 commits into
Draft
zend_objects_API: Assert that the .offset is correct in zend_object_alloc()#23101TimWolla wants to merge 2 commits into
.offset is correct in zend_object_alloc()#23101TimWolla wants to merge 2 commits into
Conversation
…t_alloc()` This makes mistakes like setting an incorrect `.offset` for the object handlers or forgetting to implement `create_object` and `clone_obj` when specifying an offset easier to debug.
Girgias
approved these changes
Aug 7, 2026
Member
|
I guess custom objects don't follow this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation is that I initially didn't implement the
.clone_objhandler forTime\Duration, since I thought I didn't need it (since I don't have allocated data there and a simple memcpy of the extra data would suffice), which lead to an obscure error in ZendMM due to pointer alignment.