Fix OPcache memory protection race under ZTS - #23081
Open
realFlowControl wants to merge 2 commits into
Open
Conversation
realFlowControl
marked this pull request as ready for review
August 6, 2026 12:35
Contributor
Author
|
Also see: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found this after adding tracing-JIT jobs to the
parallelCI, which so far only run function JIT. The new job reproducibly crashed while compiling a trace:The crash occurs because
opcache.protect_memorychanges shared-memory permissions process-wide, while ZTS threads manage the protection scopes independently.run-tests.phpsetsopcache.protect_memory=1, which is why this became visible in CI, default isopcache.protect_memory=0so most likely no one will actually see this crash in prod.The race is:
zend_shared_alloc_lock().SHM_UNPROTECT(), making OPcache shared memory writable.zend_shared_alloc_lock().SHM_UNPROTECT()followed bySHM_PROTECT().SIGSEGVorEXC_BAD_ACCESS.This PR makes unprotected sections nested and process-aware under ZTS:
The dedicated mutex is separate from
zend_shared_alloc_lock()because some callers already hold that lock when callingSHM_UNPROTECT().We do not see this in the
php-srcci in ZTS runs, because those are not running multiple threads, but everything is still single threaded.