Regenerate the expired ext/ftp/tests/cert.pem#22873
Merged
Merged
Conversation
iliaal
force-pushed
the
fix/ftp-test-cert-refresh
branch
from
July 23, 2026 15:34
1eb3e15 to
2be339b
Compare
The self-signed certificate the FTP test server presents (ext/ftp/tests/server.inc) was generated in 2016 with a ten-year validity and expired on 2026-07-23, so ext/ftp/tests and the ftps:// stream tests (ext/standard/tests/streams/opendir-003 and -004) fail the TLS handshake with "certificate expired" on every branch. Regenerate it as a self-signed CN=127.0.0.1 certificate that expires 2099-12-31, so the suite does not silently break again on a ten-year cadence.
iliaal
requested review from
Girgias,
NattyNarwhal,
SakiTakamachi,
TimWolla,
adoy,
alexdowad,
arnaud-lb,
bukka,
derickr,
devnexen,
dstogov,
kamil-tekiela,
kocsismate,
ndossche,
youkidearitai and
zeriyoshi
as code owners
July 23, 2026 15:36
iliaal
force-pushed
the
fix/ftp-test-cert-refresh
branch
from
July 23, 2026 15:36
2be339b to
bc19e5b
Compare
iliaal
removed request for
NattyNarwhal,
TimWolla,
adoy,
alexdowad,
arnaud-lb,
bukka,
derickr,
dstogov and
youkidearitai
July 23, 2026 15:38
iliaal
removed request for
Girgias,
SakiTakamachi,
devnexen,
kamil-tekiela,
kocsismate,
ndossche and
zeriyoshi
July 23, 2026 15:38
ndossche
approved these changes
Jul 23, 2026
LamentXU123
approved these changes
Jul 23, 2026
Member
|
8.2 is protected. So we might wait for someone in the security team to merge this. |
NattyNarwhal
added a commit
that referenced
this pull request
Jul 23, 2026
* PHP-8.5: Regenerate the expired ext/ftp/tests/cert.pem (#22873)
pull Bot
pushed a commit
to edisplay/php-src
that referenced
this pull request
Jul 23, 2026
* PHP-8.2: Regenerate the expired ext/ftp/tests/cert.pem (php#22873)
pull Bot
pushed a commit
to edisplay/php-src
that referenced
this pull request
Jul 23, 2026
* PHP-8.3: Regenerate the expired ext/ftp/tests/cert.pem (php#22873)
pull Bot
pushed a commit
to edisplay/php-src
that referenced
this pull request
Jul 23, 2026
* PHP-8.4: Regenerate the expired ext/ftp/tests/cert.pem (php#22873)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The self-signed certificate the FTP test server presents (ext/ftp/tests/cert.pem, loaded by server.inc) was generated in 2016 with a ten-year validity and expired on 2026-07-23 12:37 UTC, so ext/ftp/tests and the ftps:// stream tests (ext/standard/tests/streams/opendir-003 and -004) now fail the TLS handshake with "certificate expired" on every branch. This regenerates it as a self-signed CN=127.0.0.1 certificate that expires 2099-12-31, so the suite does not silently break again on a ten-year cadence.