Guard var_dump()/debug_zval_dump() against native stack overflow#22871
Open
iliaal wants to merge 1 commit into
Open
Guard var_dump()/debug_zval_dump() against native stack overflow#22871iliaal wants to merge 1 commit into
iliaal wants to merge 1 commit into
Conversation
php_object_property_dump() and serialize() already check ZEND_CHECK_STACK_LIMIT before recursing, but php_array_element_dump() and both debug_zval_dump() element helpers do not, so a deeply nested array or object crashes the process instead of printing "nesting level too deep". Add the same guard to those three helpers. var_export() overflows the same way but needs a throw-based guard, left for a separate change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A deeply nested array or object passed to var_dump() or debug_zval_dump() overflows the native C stack and segfaults. The object path of var_dump() and serialize() already guard their recursion with ZEND_CHECK_STACK_LIMIT; the array element helper and both debug_zval_dump() helpers were missing it. var_export() overflows the same way but needs a throw-based guard, left for a separate change.