ext/iconv/tests/bug48147.phpt: blacklist unknown iconv#22552
Open
orlitzky wants to merge 1 commit into
Open
Conversation
This test is for the behavior of iconv's magic "//IGNORE" suffix. The output it expects appears to agree with POSIX 2024 even when the underlying implementation (glibc) does not. A comment has been added to this effect, and two calls to urlencode() have been removed so that two (expected) errors are not swallowed. Afterwards we blacklist the "unknown" ICONV_IMPL, with musl in mind. Despite what POSIX says, support for //IGNORE is far from standard. We are checking for morally-correct results, however, so we opt for a blacklist rather than a whitelist of implementations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the last failure in #22413
PHP has
ICONV_BROKEN_IGNOREfor implementations (glibc) that return anEILSEQwhen they//IGNOREan invalid sequence, but some implementations (musl) don't support//IGNOREat all. We blacklist those implementations in the test since//IGNOREis now part of the standard (not supporting it is "bad"), but there is nothing PHP can do about it.Whatever libc does ultimately has to be OK. I think this needs better documentation (php/doc-en#5646) rather than more code.
We should probably be blacklisting BSD and IBM iconv as well, but I don't have them available to test.