Skip to content

stream filters: only accept array params for write_seek_mode param #22357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Girgias merged 1 commit into from
Jun 18, 2026
+6 −7
Merged

stream filters: only accept array params for write_seek_mode param #22357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions main/streams/filter.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,26 +277,25 @@ PHPAPI php_stream_filter *_php_stream_filter_alloc(const php_stream_filter_ops *
}

PHPAPI zend_result php_stream_filter_parse_write_seek_mode(
zval *filterparams,
const zval *filterparams,
php_stream_filter_seekable_t *write_seekable)
{
*write_seekable = PSFS_SEEKABLE_ALWAYS;

if (filterparams == NULL) {
return SUCCESS;
}
if (Z_TYPE_P(filterparams) != IS_ARRAY && Z_TYPE_P(filterparams) != IS_OBJECT) {
if (Z_TYPE_P(filterparams) != IS_ARRAY) {
return SUCCESS;
}

zval *tmp = zend_hash_str_find_ind(HASH_OF(filterparams),
"write_seek_mode", sizeof("write_seek_mode") - 1);
if (tmp == NULL) {
const zval *write_seek_mode = zend_hash_str_find(Z_ARR_P(filterparams), ZEND_STRL("write_seek_mode"));
if (write_seek_mode == NULL) {
return SUCCESS;
}

zend_string *tmp_str;
zend_string *str = zval_get_tmp_string(tmp, &tmp_str);
const zend_string *str = zval_get_tmp_string(write_seek_mode, &tmp_str);
zend_result result = SUCCESS;

if (zend_string_equals_literal(str, "preserve")) {
Expand Down
2 changes: 1 addition & 1 deletion main/streams/php_stream_filter_api.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ PHPAPI void php_stream_filter_free(php_stream_filter *filter);
PHPAPI php_stream_filter *_php_stream_filter_alloc(const php_stream_filter_ops *fops,
void *abstract, bool persistent, php_stream_filter_seekable_t read_seekable,
php_stream_filter_seekable_t write_seekable STREAMS_DC);
PHPAPI zend_result php_stream_filter_parse_write_seek_mode(zval *filterparams,
PHPAPI zend_result php_stream_filter_parse_write_seek_mode(const zval *filterparams,
php_stream_filter_seekable_t *write_seekable);
PHPAPI int php_stream_filter_get_chain_type(php_stream *stream, php_stream_filter *filter);

Expand Down
Loading