Skip to content

date: Fix typo in condition in date_period_init_iso8601_string()#22253

Open
ndossche wants to merge 1 commit into
php:PHP-8.4from
ndossche:date-typo
Open

date: Fix typo in condition in date_period_init_iso8601_string()#22253
ndossche wants to merge 1 commit into
php:PHP-8.4from
ndossche:date-typo

Conversation

@ndossche
Copy link
Copy Markdown
Member

@ndossche ndossche commented Jun 7, 2026

Now the address is being checked instead of the value, but I believe the value should be checked against 0, not the pointer against NULL.

Found by static analysis.

Now the address is being checked instead of the value, but I believe the
value should be checked against 0, not the pointer against NULL.
@ndossche ndossche requested a review from kocsismate June 7, 2026 21:08
@ndossche ndossche requested a review from derickr as a code owner June 7, 2026 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant