ext/zip: Make ZipArchive non-serializable#22237
Open
k2gl wants to merge 1 commit into
Open
Conversation
A ZipArchive wraps a libzip resource that cannot survive serialization, so unserialize() silently produced a broken object (numFiles = 0) instead of erroring. Mark the class as not-serializable, consistent with Socket, CurlHandle and the Dba classes. Fixes phpGH-21682
5f927a3 to
8fe20ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
ZipArchivewraps a libzip resource that cannot survive serialization, sounserialize()silently produced a broken object (numFiles = 0) instead of erroring. This marks the class as not-serializable, consistent withSocket,CurlHandleand the Dba classes.Fixes GH-21682