ext/intl: Fix ResourceBundle fallback-disabled error message#22236
Open
LamentXU123 wants to merge 1 commit into
Open
ext/intl: Fix ResourceBundle fallback-disabled error message#22236LamentXU123 wants to merge 1 commit into
LamentXU123 wants to merge 1 commit into
Conversation
bfe35e5 to
a9a161e
Compare
a9a161e to
fdee518
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When ResourceBundle::get() rejects fallback results when fallback is disabled
Original error message:
It should be
I also change the declaration line of
icuerrorto make it initialized. Not sure if this worth NEWS and UPGRADING entries but I am targeting master as this is actually a typo fix.