Skip to content

Fix stream_context_set_option() mutating the default context #22235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nicolas-grekas wants to merge 1 commit into
base: master
Choose a base branch
from
+35 −1
Open

Fix stream_context_set_option() mutating the default context #22235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions ext/standard/tests/streams/stream_context_set_option_no_default_leak.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
--TEST--
stream_context_set_option() on a context-less stream must not leak into the default context
--FILE--
<?php
$a = fopen('php://memory', 'r+');
stream_context_set_option($a, 'http', 'filename', 'test.txt');

// The default context must stay untouched.
var_dump(stream_context_get_options(stream_context_get_default()));

// A later context-less stream must not inherit the option.
$b = fopen('php://memory', 'r+');
var_dump(stream_context_get_options($b));

// The stream the option was set on keeps it for itself.
var_dump(stream_context_get_options($a));
?>
--EXPECT--
array(0) {
}
array(0) {
}
array(1) {
["http"]=>
array(1) {
["filename"]=>
string(8) "test.txt"
}
}
7 changes: 6 additions & 1 deletion main/streams/streams.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2248,7 +2248,12 @@ PHPAPI php_stream *_php_stream_open_wrapper_ex(const char *path, const char *mod
stream->open_filename = __zend_orig_filename ? __zend_orig_filename : __zend_filename;
stream->open_lineno = __zend_orig_lineno ? __zend_orig_lineno : __zend_lineno;
#endif
if (stream->ctx == NULL && context != NULL && !persistent) {
/* Attach an explicitly provided context to the stream, but never the
* default context: sharing it by reference would let a later
* stream_context_set_option() on the stream mutate the global default
* context, leaking options into every other stream. Stream errors fall
* back to the default context on their own when the stream has none. */
if (stream->ctx == NULL && context != NULL && context != FG(default_context) && !persistent) {
php_stream_context_set(stream, context);
}
}
Expand Down
Loading