Fixed GH-22216: don't warn in OnUpdateMemoryConsumption on ZTS thread init#22225
Open
dkkoma wants to merge 1 commit into
Open
Fixed GH-22216: don't warn in OnUpdateMemoryConsumption on ZTS thread init#22225dkkoma wants to merge 1 commit into
dkkoma wants to merge 1 commit into
Conversation
…ead init The ZTS per-thread ini refresh runs on_modify at ZEND_INI_STAGE_STARTUP to populate the new thread's globals; skip the accel_startup_ok guard there so it is not treated as a post-startup change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes GH-22216
Testing
Put this as
/tmp/ztsrepro/repro_min.cBuild php-src with --enable-zts --enable-embed, Run the following from the build root
ini
before
after