Skip to content

ext/standard: http(s) wrapper corrupts the basic auth header on perce… #22172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devnexen wants to merge 1 commit into
base: PHP-8.5
Choose a base branch
from
+49 −2
Open

ext/standard: http(s) wrapper corrupts the basic auth header on perce… #22172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ext/standard/http_fopen_wrapper.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -758,14 +758,14 @@ static php_stream *php_stream_url_wrap_http_ex(php_stream_wrapper *wrapper,
smart_str scratch = {0};

/* decode the strings first */
php_url_decode(ZSTR_VAL(resource->user), ZSTR_LEN(resource->user));
ZSTR_LEN(resource->user) = php_url_decode(ZSTR_VAL(resource->user), ZSTR_LEN(resource->user));

smart_str_append(&scratch, resource->user);
smart_str_appendc(&scratch, ':');

/* Note: password is optional! */
if (resource->password) {
php_url_decode(ZSTR_VAL(resource->password), ZSTR_LEN(resource->password));
ZSTR_LEN(resource->password) = php_url_decode(ZSTR_VAL(resource->password), ZSTR_LEN(resource->password));
smart_str_append(&scratch, resource->password);
}

Expand Down
47 changes: 47 additions & 0 deletions ext/standard/tests/http/gh22171.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
--TEST--
GH-22171 (http(s) stream wrapper sends a corrupted Authorization header for percent-encoded userinfo)
--SKIPIF--
<?php require 'server.inc'; http_server_skipif(); ?>
--INI--
allow_url_fopen=1
--FILE--
<?php
require 'server.inc';

function probe(string $label, string $userinfo, string $expected): void
{
$responses = array(
"data://text/plain,HTTP/1.0 200 Ok\r\n\r\n",
);

['pid' => $pid, 'uri' => $uri] = http_server($responses, $output);

$url = preg_replace('#^http://#', 'http://' . $userinfo . '@', $uri);
file_get_contents($url);

http_server_kill($pid);

fseek($output, 0, SEEK_SET);
$output = stream_get_contents($output);

if (preg_match('/^Authorization:\s*Basic\s+(\S+)/mi', $output, $m)) {
$decoded = base64_decode($m[1]);
} else {
$decoded = '<no Authorization header>';
}

echo "=== {$label} ===", PHP_EOL;
echo " decoded : ", addcslashes($decoded, "\0..\37"), PHP_EOL;
echo " result : ", ($decoded === $expected ? "OK" : "CORRUPT"), PHP_EOL;
}

probe('user only', '%76%6f%72%74%66%75', 'vortfu:');
probe('user + password', '%76%6f%72%74%66%75:%70%61%73%73%77%6f%72%64', 'vortfu:password');
?>
--EXPECT--
=== user only ===
decoded : vortfu:
result : OK
=== user + password ===
decoded : vortfu:password
result : OK
Loading