ext/uri: Fix static build on Windows by defining LEXBOR_STATIC#22165
Open
luthermonson wants to merge 1 commit into
Open
ext/uri: Fix static build on Windows by defining LEXBOR_STATIC#22165luthermonson wants to merge 1 commit into
luthermonson wants to merge 1 commit into
Conversation
Member
|
I know nothing about Windows. Should / Must this be fixed in ext/lexbor instead? |
PHP bundles lexbor as a static-only extension (ext/lexbor/config.w32
declares EXTENSION("lexbor", ..., false /* never shared */)). On
Windows, ext/lexbor/lexbor/core/def.h defaults LXB_API to
__declspec(dllimport) when LEXBOR_STATIC is not defined, which causes
LNK2019 unresolved external symbol errors for every lxb_* function
referenced from consumers (ext/uri today, potentially others later)
when PHP itself is linked statically without a runtime DLL.
Default LEXBOR_STATIC at the top of the vendored def.h so the
PHP-bundled copy is always static-API regardless of consumer. The
existing #ifndef-guarded block below this addition is preserved
verbatim so the change is functionally a no-op for callers that
already set LEXBOR_STATIC explicitly.
This is a vendor patch to a copy of upstream lexbor and will need to
be re-applied on the next lexbor upgrade (most recent was v2.7.0 per
8.5.6 NEWS); the patch is three lines and intentionally adjacent to
the existing LEXBOR_STATIC handling so it is unlikely to drift.
dad77e8 to
da128c4
Compare
Author
|
I think your instinct is correct, i"m running a test right now with a change to lexbor and will report back |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ext/uriis always built statically and pulls in the bundled lexbor headers via/I ext/lexbor. On Windows, lexbor'sLXB_APImacro defaults to__declspec(dllimport)whenLEXBOR_STATICisn't defined. As a result, when PHP itself is linked statically (no DLL) on Windows, everylxb_*symbol referenced fromext/urifails to resolve: