[ext/standard] Move min/max array fallback into array.c#22147
Open
mehmetcansahin wants to merge 1 commit into
Open
[ext/standard] Move min/max array fallback into array.c#22147mehmetcansahin wants to merge 1 commit into
mehmetcansahin wants to merge 1 commit into
Conversation
Girgias
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to @Girgias' review on #22127: this splits out the behavior-preserving baseline refactor before the numeric min()/max() fast path work.
Split out from #22127 as the behavior-preserving baseline refactor requested during review.
This moves the generic min()/max() array fallback out of the Zend HashTable API and into ext/standard/array.c, where it is the only remaining user. The local helper uses the regular ZEND_HASH_FOREACH_VAL() API and calls zend_compare() directly, avoiding the previous function-pointer wrapper.
UPGRADING.INTERNALS is updated to document that zend_hash_minmax() is no longer exposed.
Compatibility check: Sourcegraph search only found stale vendored/documentation copies plus one old PHP 7.x extension (
viest/php-ext-collection) using this internal symbol. The removal is documented in UPGRADING.INTERNALS.Tested with: