ini_get_all(): Add builtin_default_value column#22134
Open
sebastianbergmann wants to merge 3 commits into
Open
ini_get_all(): Add builtin_default_value column#22134sebastianbergmann wants to merge 3 commits into
builtin_default_value column#22134sebastianbergmann wants to merge 3 commits into
Conversation
mvorisek
reviewed
May 23, 2026
ini_get_all() with the compiled-in default value of a PHP INI setting
bukka
approved these changes
May 23, 2026
Member
bukka
left a comment
There was a problem hiding this comment.
LGTM. Let's give it a little bit of time for others to check
TimWolla
reviewed
May 23, 2026
Member
TimWolla
left a comment
There was a problem hiding this comment.
Implementation LGTM, I just have opinions about the color of the bikeshed.
ini_get_all() with the compiled-in default value of a PHP INI settingini_get_all() with the built-in default value of a PHP INI setting
TimWolla
approved these changes
May 23, 2026
ini_get_all() with the built-in default value of a PHP INI settingbuiltin_default_value column
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements an additional column for
ini_get_all()with the compiled-in default value of a PHP INI setting as suggested in #22133.