sapi/cli/tests/php_cli_server_ipv6_error_message.phpt: ignore warning#22015
Open
orlitzky wants to merge 1 commit into
Open
sapi/cli/tests/php_cli_server_ipv6_error_message.phpt: ignore warning#22015orlitzky wants to merge 1 commit into
orlitzky wants to merge 1 commit into
Conversation
…ions This test is checking for brackets around an ipv6 address. On some systems, a PHP warning is emitted before printing the expected output; for example, [Fri May 8 17:24:55 2026] PHP Warning: Unknown: php_network_getaddresses: getaddrinfo for 2001:db8:: failed: Address family for hostname not supported in Unknown on line 0 [Fri May 8 17:24:55 2026] Failed to listen on [2001:db8::]:8080 (reason: php_network_getaddresses: getaddrinfo for 2001:db8:: failed: Address family for hostname not supported) Only the second of these is expected by the test, causing it to fail on those systems. The warning does not seem harmful however, so with a small tweak to the expected output, we can ignore everything up to the bracketed ipv6 address. This is ultimately the purpose of the test, to ensure that the address prints with brackets.
Contributor
Author
|
I'm not quite sure where the warning comes from. It isn't due to a lack of ipv6, and it only happens as part of our package test suite where internet access blocked. |
Contributor
|
This makes sense. However, the %A will ignore all warnings. So I will suggest you to use EXPECTREGEX instead here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test is checking for brackets around an ipv6 address. On some systems, a PHP warning is emitted before printing the expected output; for example,
Only the second of these is expected by the test, causing it to fail on those systems. The warning does not seem harmful however, so with a small tweak to the expected output, we can ignore everything up to the bracketed ipv6 address. This is ultimately the purpose of the test, to ensure that the address prints with brackets.
CC: @alexandre-daubois