Fix enum case conflict in trait binding#21771
Open
prateekbhujel wants to merge 1 commit intophp:masterfrom
Open
Fix enum case conflict in trait binding#21771prateekbhujel wants to merge 1 commit intophp:masterfrom
prateekbhujel wants to merge 1 commit intophp:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21760.
Trait constant binding currently assumes that an existing entry in the constants table is a normal class constant. If the existing entry is an enum case with the same name, that path crashes instead of rejecting the conflict cleanly.
Reject that conflict up front during trait constant binding and cover it with a regression test.