Skip to content

[FrankenPHP] Make php-cli functionality available in embed build #21354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
henderkes wants to merge 8 commits into
base: master
Choose a base branch
from
Open

[FrankenPHP] Make php-cli functionality available in embed build #21354

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b54fce7
rename sapi/cli/php_cli.c::main() to do_php_cli()
henderkes Mar 6, 2026
fd33542
Merge remote-tracking branch 'php/master' into feat/embed-cli
henderkes Mar 7, 2026
059fe19
force feature checks on cli sapi to run when we use embed sapi
henderkes Mar 7, 2026
cdc207b
require cli sapi instead?
henderkes Mar 7, 2026
5794331
move to main/cli folder
henderkes Mar 10, 2026
ddee033
fix compilation
henderkes Mar 10, 2026
6673f26
fix w32
henderkes Mar 10, 2026
1efa959
move stub file
henderkes Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix w32
  • Loading branch information
@henderkes
henderkes committed Mar 10, 2026
commit 6673f26ded9cb576c23862ef9c18360dab1b9777
5 changes: 5 additions & 0 deletions sapi/cli/cli_win32.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,7 @@
#define PHP_CLI_WIN32_NO_CONSOLE 1
#include "main/cli/php_cli.c"

int WINAPI WinMain(HINSTANCE hInstance, HINSTANCE hPrevInstance, LPSTR lpCmdLine, int nShowCmd)
{
return do_php_cli(__argc, __argv);
}
1 change: 1 addition & 0 deletions sapi/cli/config.w32
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,6 @@ if (PHP_CLI_WIN32 == "yes") {
SAPI('cli_win32', 'cli_win32.c', 'php-win.exe', '/DZEND_ENABLE_STATIC_TSRMLS_CACHE=1');
ADD_SOURCES("main/cli", "php_cli_process_title.c ps_title.c", "cli_win32", undefined, PHP_CLI == "yes");
ADD_FLAG("LDFLAGS_CLI_WIN32", "/stack:67108864");
ADD_FLAG("LIBS_CLI_WIN32", "ws2_32.lib");
ADD_FLAG("LIBS_CLI_WIN32", "shell32.lib");
}
Loading