Fix GH-19705: do not flush/write buffer on non writeable stream.#19708
Closed
devnexen wants to merge 3 commits intophp:PHP-8.3from
Closed
Fix GH-19705: do not flush/write buffer on non writeable stream.#19708devnexen wants to merge 3 commits intophp:PHP-8.3from
devnexen wants to merge 3 commits intophp:PHP-8.3from
Conversation
Member
Author
|
ping :) |
bukka
requested changes
Oct 1, 2025
Member
bukka
left a comment
There was a problem hiding this comment.
The approach was good in general - just not emitting warning is more consistent IMO - there is really no point to warn here because it's just a buffered rubbish from the filter so it can be safely ignored.
bukka
approved these changes
Oct 2, 2025
Member
bukka
left a comment
There was a problem hiding this comment.
Looks good now.
You might consider to add me with Co-authored-by considering that it's pretty much just what I added in suggestions... :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.