zend_ulong_ntz/zend_ulong_ntz little optimisation for windows.#17527
Closed
devnexen wants to merge 1 commit into
Closed
zend_ulong_ntz/zend_ulong_ntz little optimisation for windows.#17527devnexen wants to merge 1 commit into
devnexen wants to merge 1 commit into
Conversation
because of the unix code path, UB is avoided beforehand thus errors with 0 mask for the windows api is unlikely.
Member
Author
|
nvm pretty pointless, with clang it s the same as unix and unexpected is no-op with msvc.. |
Member
Is it? It looks like clang-cl actually takes the However, I don't think either return value is expected (or unexpected). It seems to me the comment "undefined behavior" is very misleading. It's just when |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
because of the unix code path, UB is avoided beforehand thus errors with 0 mask for the windows api is unlikely.