Skip to content

x86 builds on Windows are warning level 1 clean - #16170

Merged
cmb69 merged 3 commits into
php:masterfrom
cmb69:cmb/x86-wx
Oct 3, 2024
Merged

x86 builds on Windows are warning level 1 clean#16170
cmb69 merged 3 commits into
php:masterfrom
cmb69:cmb/x86-wx

Conversation

@cmb69

@cmb69 cmb69 commented Oct 2, 2024

Copy link
Copy Markdown
Member

The only issue that was left was due to the old build of net-snmp 5.7.3; since updating to net-snmp 5.9.4, this is resolved.

cmb69 added 2 commits October 2, 2024 12:53
The only issue that was left was due to the old build of net-snmp 5.7.3;
since updating to net-snmp 5.9.4, this is resolved.
@Girgias

Girgias commented Oct 2, 2024

Copy link
Copy Markdown
Member

Follow-up question: what would enabling W2 warnings entail?

@cmb69

cmb69 commented Oct 2, 2024

Copy link
Copy Markdown
Member Author

what would enabling W2 warnings entail?

Amongst others, C4146, which appear to be bogus (see #15106).

PS: we're likely better off addressing clang warnings on Windows.

@cmb69
cmb69 marked this pull request as ready for review October 2, 2024 11:51
@cmb69
cmb69 requested a review from TimWolla as a code owner October 2, 2024 11:51
@cmb69

cmb69 commented Oct 2, 2024

Copy link
Copy Markdown
Member Author

Note to merger: credit @mvorisek (see #8479 (comment))

@TimWolla
TimWolla removed their request for review October 2, 2024 14:37
@cmb69
cmb69 merged commit fbfc899 into php:master Oct 3, 2024
@cmb69
cmb69 deleted the cmb/x86-wx branch October 3, 2024 10:56
adrian-enspired pushed a commit to adrian-enspired/php-src that referenced this pull request Aug 4, 2026
The only issue that was left was due to the old build of net-snmp 5.7.3; since updating to net-snmp 5.9.4, this is resolved.

The patch has originally been provided by @mvorisek.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants