Skip to content

Sync HAVE_<extension> help texts#15167

Merged
petk merged 3 commits into
php:masterfrom
petk:patch-AC_DEFINE-extensions
Aug 1, 2024
Merged

Sync HAVE_<extension> help texts#15167
petk merged 3 commits into
php:masterfrom
petk:patch-AC_DEFINE-extensions

Conversation

@petk
Copy link
Copy Markdown
Member

@petk petk commented Jul 30, 2024 •
edited
Loading

This syncs all help texts of extension preprocessor macros to the same style Define to 1 if PHP extension '<ext>' is available..

SakiTakamachi
SakiTakamachi reviewed Jul 30, 2024
View reviewed changes
Comment thread ext/xsl/config.w32 Outdated
@petk
Copy link
Copy Markdown
Member Author

petk commented Aug 1, 2024

In the appended commit, I've only changed the CS in M4 files a bit and used this help text instead (minor grammar correction):
Define to 1 if the PHP extension 'extension_name' is available.

petk added 3 commits August 2, 2024 01:36
@petk
Sync HAVE_<extension> help texts
443e87b 
This syncs all help texts of extension preprocessor macros to the same
style "Define to 1 if PHP extension '<ext>' is available.".
@petk
[skip ci] Fix typo s/xml/xsl
a8d47c6
@petk
[skip ci] Add 'the' before PHP extension
48f8d5f 
To make this sound a bit better and to be a bit in sync with the
COMPILE_DL_<ext>, help texts are:

    Define to 1 if the PHP extension 'extension_name' is available.
@petk petk force-pushed the patch-AC_DEFINE-extensions branch from 60bcf67 to 48f8d5f Compare August 1, 2024 23:38
@petk petk merged commit f66feae into php:master Aug 1, 2024
@petk petk deleted the patch-AC_DEFINE-extensions branch August 1, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NattyNarwhal NattyNarwhal NattyNarwhal approved these changes

@devnexen devnexen devnexen approved these changes

@ndossche ndossche ndossche approved these changes

@SakiTakamachi SakiTakamachi SakiTakamachi approved these changes

@Girgias Girgias Awaiting requested review from Girgias Girgias is a code owner

@bukka bukka Awaiting requested review from bukka bukka is a code owner

@alexdowad alexdowad Awaiting requested review from alexdowad alexdowad is a code owner

@youkidearitai youkidearitai Awaiting requested review from youkidearitai youkidearitai is a code owner

@dstogov dstogov Awaiting requested review from dstogov dstogov is a code owner

@adoy adoy Awaiting requested review from adoy adoy is a code owner

Assignees

No one assigned

Labels

Category: Build System Extension: bcmath Extension: bz2 Extension: calendar Extension: com_dotnet Extension: ctype Extension: curl Extension: dba Extension: dom Extension: enchant Extension: exif Extension: ffi Extension: ftp Extension: gmp Extension: iconv Extension: ldap Extension: libxml Extension: mbstring Extension: odbc Extension: openssl Extension: pdo_pgsql Extension: pgsql Extension: posix Extension: session Extension: shmop Extension: simplexml Extension: snmp Extension: soap Extension: sockets Extension: sqlite3 Extension: sysvmsg Extension: sysvsem Extension: sysvshm Extension: tidy Extension: xml Extension: xmlreader Extension: xmlwriter Extension: xsl Extension: zip Extension: zlib

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@petk @NattyNarwhal @devnexen @ndossche @SakiTakamachi