Use a single version of mempcpy(3) - #12257
Conversation
While __php_mempcpy is only used by ext/standard/crypt_sha*, the mempcpy "pattern" is used everywhere. This commit removes __php_mempcpy, adds zend_mempcpy and transforms open-coded parts into function calls.
|
No objection for |
|
The failures of the ARM_DEBUG_NTS and FREEBSD_DEBUG_NTS CI tasks are spurious. |
Did you do the replacement manually or did you leverage an automated tool (e.g. Coccinelle)? |
Manually reviewed one by one but mostly coccinelle automated (manually it will be very error prone) |
|
It might be useful to include your Coccinelle patch in the commit message / PR description for future reference then. |
Co-authored-by: Gina Peter Banyard <girgias@php.net>
suggestion from Girgias Co-authored-by: Gina Peter Banyard <girgias@php.net>
Remove line break Co-authored-by: Gina Peter Banyard <girgias@php.net>
|
Ok, sorry for the delay..I applied all suggestions now. |
|
Thank you! |
|
@crrodriguez Can you provide your Coccinelle patch as a comment in this PR for posterity? |
https://github.com/systemd/systemd/blob/main/coccinelle/mempcpy.cocci |
|
There are probably other transformations that can be done, that spatch covers the obvious only. |
While __php_mempcpy is only used by ext/standard/crypt_sha*, the mempcpy "pattern" is used everywhere. This commit removes __php_mempcpy, adds zend_mempcpy and transforms open-coded parts into function calls.
While __php_mempcpy is only used by ext/standard/crypt_sha*, the mempcpy "pattern" is used everywhere.
This commit removes __php_mempcpy, adds zend_mempcpy and transforms open-coded parts into function calls.