localtime.xml Change the parameter name + nits#4820
Open
mmalferov wants to merge 6 commits into
Open
Conversation
It looks like the name `$parse_pos` migrated from the source code. It is better to leave the name `$offset` in the user land
kamil-tekiela
requested changes
Oct 15, 2025
Co-authored-by: Kamil Tekiela <tekiela246@gmail.com>
lacatoire
reviewed
May 12, 2026
lacatoire
reviewed
May 12, 2026
lacatoire
reviewed
May 12, 2026
lacatoire
reviewed
May 12, 2026
lacatoire
reviewed
May 12, 2026
lacatoire
reviewed
May 12, 2026
Co-authored-by: Louis-Arnaud <la.catoire@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like the name
$parse_posmigrated from the source code. It is better to leave the name$offsetin the user land