Skip to content

Avoid marking files as outdated on multiple [skip-revcheck] #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alfsb merged 24 commits into from
Nov 18, 2024
Merged

Avoid marking files as outdated on multiple [skip-revcheck] #178

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
f9921a1
DTO for revcheck data.
Oct 25, 2024
d72bb52
Preparation for revcheck data exporting.
Oct 26, 2024
72453ce
Backport loose and fixed [skip-revcheck] modes
Oct 26, 2024
600714c
Additional revcheck data.
Nov 1, 2024
221e0dc
Revcheck deduplication: clean up, header.
Nov 1, 2024
83fb651
Revcheck deduplication: translators, file summary.
Nov 1, 2024
3b62b38
Revcheck deduplication: old/wip files.
Nov 5, 2024
156b0b5
Move backport code and docs to a separate file.
Nov 5, 2024
4405435
Revcheck deduplication: backport couting behaviour.
Nov 5, 2024
31cf0db
Revcheck deduplication: more backport couting woes.
Nov 5, 2024
324f48c
Revcheck deduplication: notinen, revtag, unstranslated.
Nov 5, 2024
60b5f1e
Revcheck deduplication: ignore, regex, xml.
Nov 6, 2024
a0ddca6
Revcheck deduplication: adds/dels, clean up.
Nov 6, 2024
55bae33
Revcheck deduplicatoin: genrevdb.php.
Nov 7, 2024
1ab908c
Revcheck deduplicatoin: genrevdb.php.
Nov 7, 2024
a08561f
More backport and small fixes.
Nov 7, 2024
d254ced
Review changes/fixes.
Nov 7, 2024
117a61d
Better log messages.
Nov 7, 2024
3eb4ef5
Remove unrelated filter.
Nov 8, 2024
bf4f663
Merge branch 'php:master' into master
alfsb Nov 11, 2024
e1f8400
Changes revcheck to consider one or many hashes, instead of two.
Nov 11, 2024
0460e4b
Changes revcheck to consider one or many hashes, instead of two.
Nov 11, 2024
0d5b26a
Changes revcheck to consider one or many hashes, instead of two.
Nov 11, 2024
a58d5a2
Merge branch 'php:master' into FIXED_SKIP_REVCHECK
alfsb Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Review changes/fixes.
  • Loading branch information
André L F S Bacci committed Nov 7, 2024
commit d254cede8eac11bdd07a9bd3a68a003785490526
6 changes: 4 additions & 2 deletions scripts/translation/genrevdb.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,11 @@

$timeStart = new \DateTime;
$dbpath = $argv[1];
$langs = explode( ',' , $argv[2] );
$langs = array();
for( $idx = 2 ; $idx < count( $argv ) ; $idx++ )
$langs[] = $argv[ $idx ];

consolelog( "Creating revdata database $dbpath for languages: $argv[2]." );
consolelog( "Creating revdata database $dbpath for languages: " . implode( ',', $langs ) . '.');

$db = db_create( $dbpath );
foreach( $langs as $lang )
Expand Down
13 changes: 10 additions & 3 deletions scripts/translation/lib/RevcheckRun.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,9 +224,16 @@ private function parseTranslationXml() : void

$dom = XmlUtil::loadFile( $this->targetDir . '/translation.xml' );

$this->revData->intro =
$dom->saveXML( $dom->getElementsByTagName( 'intro' )[0] )
?? "No intro available for the {$lang} translation of the manual.";
$tag = $dom->getElementsByTagName( 'intro' )[0] ?? null;
if ( $tag == null )
$intro = "No intro available for the {$this->targetDir} translation of the manual.";
else
{
$intro = "";
foreach( $tag->childNodes as $node )
$intro .= $dom->saveXML( $node );
}
$this->revData->intro = $intro;

$persons = $dom->getElementsByTagName( 'person' );
foreach( $persons as $person )
Expand Down