Make it possible to explicitly close RPC connection#150
Merged
Conversation
petertodd
added a commit
that referenced
this pull request
Nov 6, 2017
1ea9661 make it possible to explicitly close connection (Simon Mulser) 4df1bbb fix PEP8 too many blank lines (Simon Mulser) Pull request description: So far it is not possible to close a connection. you need to hope that GC does it or access `__connection` over the `__dict__` variable. This PR let the proxy expose a proper `close()` function. Tree-SHA512: 721c4bd250549264ec54b3a2f8c333dcd55ed90cfc9ff7e8720c2243ada3639785889e52adc6a2fdf4b5c670bc54e3c127b57b04215cc119d419e79794107598
Owner
|
Thanks! |
rawBit-io
pushed a commit
to rawBit-io/python-bitcointx
that referenced
this pull request
Nov 6, 2025
b74e9d0 make it possible to explicitly close connection (Simon Mulser) ff08f9a fix PEP8 too many blank lines (Simon Mulser) Pull request description: So far it is not possible to close a connection. you need to hope that GC does it or access `__connection` over the `__dict__` variable. This PR let the proxy expose a proper `close()` function. Tree-SHA512: 721c4bd250549264ec54b3a2f8c333dcd55ed90cfc9ff7e8720c2243ada3639785889e52adc6a2fdf4b5c670bc54e3c127b57b04215cc119d419e79794107598
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far it is not possible to close a connection. you need to hope that GC does it or access
__connectionover the__dict__variable.This PR let the proxy expose a proper
close()function.