Update dependencies for js branch#115
Merged
Merged
Conversation
dlabaj
approved these changes
Jun 28, 2021
adnankhan666
pushed a commit
to adnankhan666/patternfly-react-seed
that referenced
this pull request
Feb 25, 2026
Update dependencies for js branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's been a while since we've touched this branch, this PR brings the dependencies up to date and makes sure everything still builds.
Should probably spend some time reworking how these configs are put together, seems quite a bit has changed in terms of best practice in that area. Also, if anyone has a recommendation or request for how best to maintain and document the two versions of this seed project (javascript/typescript) - now is a good time to have that discussion.
I think it's valuable to have a working babel configuration for illustration purposes, but maybe considering the path is generally from JS => TS in terms of development, we drop this branch altogether and just make the main branch less type strict so that even though we're using the ts compiler, it works just fine for JS projects as well. Then, we don't need to maintain two branches in this starter project, just one. Thoughts?
Steps toward closing #114