Skip to content

Updated to core 178 and refactor from patternfly-next to patternfly.#1317

Merged
dgutride merged 4 commits into
patternfly:masterfrom
dlabaj:updatePatternfly
Feb 4, 2019
Merged

Updated to core 178 and refactor from patternfly-next to patternfly.#1317
dgutride merged 4 commits into
patternfly:masterfrom
dlabaj:updatePatternfly

Conversation

@dlabaj
Copy link
Copy Markdown
Contributor

@dlabaj dlabaj commented Feb 4, 2019

What:

Refactor from patternfly-next to patternfly to align with beta. Updated to the latest build of core 178.

Additional issues:

None

Copy link
Copy Markdown
Member

@dgutride dgutride left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - three minor fixes

Comment thread packages/patternfly-4/react-core/README.md
Comment thread packages/patternfly-4/react-styled-system/README.md
Comment thread packages/patternfly-4/react-table/README.md
Comment thread packages/patternfly-4/react-table/src/components/Table/ExpandableRowContent.js Outdated
@tlabaj tlabaj added PF4 labels Feb 4, 2019
@patternfly-build
Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://1317-pr-patternfly-react-patternfly.surge.sh

@coveralls
Copy link
Copy Markdown

coveralls commented Feb 4, 2019

Pull Request Test Coverage Report for Build 4284

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 80.225%

Totals Coverage Status
Change from base Build 4283: 0.0%
Covered Lines: 4632
Relevant Lines: 5424

💛 - Coveralls

Copy link
Copy Markdown
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgutride dgutride merged commit 9cabf54 into patternfly:master Feb 4, 2019
dgutride pushed a commit to dgutride/patternfly-react that referenced this pull request Feb 6, 2019
…atternfly#1317)

* Updated to core 178

* Updated snapshots.

* Updated with code review comments.

* Updates from rebase with table.
@dlabaj dlabaj deleted the updatePatternfly branch March 30, 2019 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants