Skip to content

fix(AngleLeftIcon): Replace AngleLeftIcon with RhMicronsCaretLeftIcon #12495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rebeccaalpert wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(AngleLeftIcon): Replace AngleLeftIcon with RhMicronsCaretLeftIcon #12495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-core/src/components/DualListSelector/examples/DualListSelector.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ propComponents:

import { Fragment, useEffect, useMemo, useState } from 'react';
import RhMicronsDoubleCaretLeftIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-double-caret-left-icon';
import AngleLeftIcon from '@patternfly/react-icons/dist/esm/icons/angle-left-icon';
import RhMicronsCaretLeftIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-left-icon';
import AngleDoubleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-double-right-icon';
import AngleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-right-icon';
import RhMicronsSortDownSmallToLargeIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-sort-down-small-to-large-icon';
Expand Down
4 changes: 2 additions & 2 deletions packages/react-core/src/components/DualListSelector/examples/DualListSelectorBasic.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import {
DualListSelectorControl
} from '@patternfly/react-core';
import RhMicronsDoubleCaretLeftIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-double-caret-left-icon';
import AngleLeftIcon from '@patternfly/react-icons/dist/esm/icons/angle-left-icon';
import RhMicronsCaretLeftIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-left-icon';
import AngleDoubleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-double-right-icon';
import AngleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-right-icon';

Expand Down Expand Up @@ -123,7 +123,7 @@ export const DualListSelectorBasic: React.FunctionComponent = () => {
onClick={() => moveSelected(false)}
isDisabled={!chosenOptions.some((option) => option.selected)}
aria-label="Remove selected"
icon={<AngleLeftIcon />}
icon={<RhMicronsCaretLeftIcon />}
/>
</DualListSelectorControlsWrapper>
<DualListSelectorPane
Expand Down
4 changes: 2 additions & 2 deletions packages/react-core/src/components/DualListSelector/examples/DualListSelectorBasicSearch.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import {
EmptyStateActions
} from '@patternfly/react-core';
import RhMicronsDoubleCaretLeftIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-double-caret-left-icon';
import AngleLeftIcon from '@patternfly/react-icons/dist/esm/icons/angle-left-icon';
import RhMicronsCaretLeftIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-left-icon';
import AngleDoubleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-double-right-icon';
import AngleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-right-icon';
import SearchIcon from '@patternfly/react-icons/dist/esm/icons/search-icon';
Expand Down Expand Up @@ -171,7 +171,7 @@ export const DualListSelectorSearch: React.FunctionComponent = () => {
onClick={() => moveSelected(false)}
isDisabled={!chosenOptions.some((option) => option.selected)}
aria-label="Remove selected"
icon={<AngleLeftIcon />}
icon={<RhMicronsCaretLeftIcon />}
/>
</DualListSelectorControlsWrapper>
<DualListSelectorPane
Expand Down
4 changes: 2 additions & 2 deletions ...ges/react-core/src/components/DualListSelector/examples/DualListSelectorBasicTooltips.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import {
DualListSelectorControl
} from '@patternfly/react-core';
import RhMicronsDoubleCaretLeftIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-double-caret-left-icon';
import AngleLeftIcon from '@patternfly/react-icons/dist/esm/icons/angle-left-icon';
import RhMicronsCaretLeftIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-left-icon';
import AngleDoubleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-double-right-icon';
import AngleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-right-icon';

Expand Down Expand Up @@ -131,7 +131,7 @@ export const DualListSelectorBasic: React.FunctionComponent = () => {
aria-label="Remove selected"
tooltipContent="Remove selected"
tooltipProps={{ position: 'bottom', 'aria-live': 'off' }}
icon={<AngleLeftIcon />}
icon={<RhMicronsCaretLeftIcon />}
/>
</DualListSelectorControlsWrapper>
<DualListSelectorPane
Expand Down
4 changes: 2 additions & 2 deletions ...t-core/src/components/DualListSelector/examples/DualListSelectorComplexOptionsActions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import {
MenuToggleElement
} from '@patternfly/react-core';
import RhMicronsDoubleCaretLeftIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-double-caret-left-icon';
import AngleLeftIcon from '@patternfly/react-icons/dist/esm/icons/angle-left-icon';
import RhMicronsCaretLeftIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-left-icon';
import AngleDoubleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-double-right-icon';
import AngleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-right-icon';
import RhMicronsSortDownSmallToLargeIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-sort-down-small-to-large-icon';
Expand Down Expand Up @@ -289,7 +289,7 @@ export const DualListSelectorComplexOptionsActionsNext: React.FunctionComponent
onClick={() => moveSelected(false)}
isDisabled={!chosenOptions.some((option) => option.selected) || isDisabled}
aria-label="Remove selected"
icon={<AngleLeftIcon />}
icon={<RhMicronsCaretLeftIcon />}
/>
</DualListSelectorControlsWrapper>
<DualListSelectorPane
Expand Down
4 changes: 2 additions & 2 deletions packages/react-core/src/components/DualListSelector/examples/DualListSelectorTree.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import {
EmptyStateActions
} from '@patternfly/react-core';
import RhMicronsDoubleCaretLeftIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-double-caret-left-icon';
import AngleLeftIcon from '@patternfly/react-icons/dist/esm/icons/angle-left-icon';
import RhMicronsCaretLeftIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-left-icon';
import AngleDoubleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-double-right-icon';
import AngleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-right-icon';
import SearchIcon from '@patternfly/react-icons/dist/esm/icons/search-icon';
Expand Down Expand Up @@ -308,7 +308,7 @@ export const DualListSelectorComposableTree: React.FunctionComponent<ExampleProp
onClick={() => moveChecked(false)}
isDisabled={!checkedLeafIds.filter((x) => visibleChosenLeafIds.includes(x)).length}
aria-label="Remove selected"
icon={<AngleLeftIcon />}
icon={<RhMicronsCaretLeftIcon />}
/>
</DualListSelectorControlsWrapper>
{buildPane(true)}
Expand Down
4 changes: 2 additions & 2 deletions packages/react-core/src/components/Pagination/PaginationNavigation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { Component } from 'react';
import styles from '@patternfly/react-styles/css/components/Pagination/pagination';
import { css } from '@patternfly/react-styles';
import AngleLeftIcon from '@patternfly/react-icons/dist/esm/icons/angle-left-icon';
import RhMicronsCaretLeftIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-left-icon';
import RhMicronsDoubleCaretLeftIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-double-caret-left-icon';
import AngleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-right-icon';
import AngleDoubleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-double-right-icon';
Expand Down Expand Up @@ -211,7 +211,7 @@ class PaginationNavigation extends Component<PaginationNavigationProps, Paginati
this.setState({ userInputPage: newPage });
}}
aria-label={toPreviousPageAriaLabel}
icon={<AngleLeftIcon />}
icon={<RhMicronsCaretLeftIcon />}
/>
</div>
{!isCompact && (
Expand Down
20 changes: 4 additions & 16 deletions ...omponents/Pagination/__tests__/Generated/__snapshots__/PaginationNavigation.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,24 +64,12 @@ exports[`Navigation should match snapshot (auto-generated) 1`] = `
fill="currentColor"
height="1em"
role="img"
viewBox="0 0 20 20"
width="1em"
>
<svg
class="pf-v6-icon-default"
viewBox="0 0 256 512"
>
<path
d="M31.7 239l136-136c9.4-9.4 24.6-9.4 33.9 0l22.6 22.6c9.4 9.4 9.4 24.6 0 33.9L127.9 256l96.4 96.4c9.4 9.4 9.4 24.6 0 33.9L201.7 409c-9.4 9.4-24.6 9.4-33.9 0l-136-136c-9.5-9.4-9.5-24.6-.1-34z"
/>
</svg>
<svg
class="pf-v6-icon-rh-ui"
viewBox="0 0 32 32"
>
<path
d="M21 30a.997.997 0 0 1-.707-.293L7.647 17.061a1.501 1.501 0 0 1 0-2.121L20.293 2.293a.999.999 0 1 1 1.414 1.414L9.414 16l12.293 12.293A.999.999 0 0 1 21 30Z"
/>
</svg>
<path
d="m6.41 10 7.29-7.29.02-.02c.38-.4.37-1.03-.02-1.41-.4-.38-1.03-.37-1.41.02L4.64 8.95a1.49 1.49 0 0 0 0 2.12l7.65 7.65c.19.19.44.29.71.29.27 0 .52-.11.71-.29a.996.996 0 0 0 0-1.41l-7.29-7.29Z"
/>
</svg>
</span>
</button>
Expand Down
Loading
Loading