fix(CodeBranchIcon): Replace CodeBranchIcon with RhUiBranchIcon#12489
fix(CodeBranchIcon): Replace CodeBranchIcon with RhUiBranchIcon#12489rebeccaalpert wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (36)
✅ Files skipped from review due to trivial changes (18)
🚧 Files skipped from review as they are similar to previous changes (18)
WalkthroughAll occurrences of ChangesIcon substitution across all examples and demos
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Preview: https://pf-react-pr-12489.surge.sh A11y report: https://pf-react-pr-12489-a11y.surge.sh |
8675069 to
1fb5aa3
Compare
|
needs rebase |
bekah-stephens
left a comment
There was a problem hiding this comment.
I'm wondering if the filled version of the branch icon would look better visually?
1fb5aa3 to
c0c0cb8
Compare
|
I just pushed a second commit with filled @bekah-stephens - let me know what you think. |
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
e2c5a9c to
b017cc5
Compare
bekah-stephens
left a comment
There was a problem hiding this comment.
the filled branch icon looks much better!
We might want a microns version for this - it looks significantly lighter weight-wise.
Part of #12401. Breaking into separate PRs so it is easier to review.
Made with Cursor
Summary by CodeRabbit
Style
Documentation
Visual updates only—no changes to behavior or public APIs.