Skip to content

fix(PficonSortCommonAscIcon): Replace PficonSortCommonAscIcon with RhUiSortDownSmallToLargeIcon #12485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicolethoen merged 2 commits into from
Jun 18, 2026
Merged

fix(PficonSortCommonAscIcon): Replace PficonSortCommonAscIcon with RhUiSortDownSmallToLargeIcon #12485

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
082288d
fix(PficonSortCommonAscIcon): Replace PficonSortCommonAscIcon with Rh…
rebeccaalpert Jun 16, 2026
58d4ad0
fix(PficonSortCommonAscIcon): Use RhMicronsSortDownSmallToLargeIcon i…
rebeccaalpert Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-core/src/components/DualListSelector/examples/DualListSelector.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import RhMicronsDoubleCaretLeftIcon from '@patternfly/react-icons/dist/esm/icons
import AngleLeftIcon from '@patternfly/react-icons/dist/esm/icons/angle-left-icon';
import AngleDoubleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-double-right-icon';
import AngleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-right-icon';
import PficonSortCommonAscIcon from '@patternfly/react-icons/dist/esm/icons/pficon-sort-common-asc-icon';
import RhMicronsSortDownSmallToLargeIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-sort-down-small-to-large-icon';
import SearchIcon from '@patternfly/react-icons/dist/esm/icons/search-icon';
import RhUiEllipsisVerticalFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-ellipsis-vertical-fill-icon';
import { DragDropSort, DragDropContainer, Droppable as NewDroppable } from '@patternfly/react-drag-drop';
Expand Down
6 changes: 3 additions & 3 deletions ...t-core/src/components/DualListSelector/examples/DualListSelectorComplexOptionsActions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import RhMicronsDoubleCaretLeftIcon from '@patternfly/react-icons/dist/esm/icons
import AngleLeftIcon from '@patternfly/react-icons/dist/esm/icons/angle-left-icon';
import AngleDoubleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-double-right-icon';
import AngleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-right-icon';
import PficonSortCommonAscIcon from '@patternfly/react-icons/dist/esm/icons/pficon-sort-common-asc-icon';
import RhMicronsSortDownSmallToLargeIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-sort-down-small-to-large-icon';
import SearchIcon from '@patternfly/react-icons/dist/esm/icons/search-icon';
import RhUiEllipsisVerticalFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-ellipsis-vertical-fill-icon';

Expand Down Expand Up @@ -155,7 +155,7 @@ export const DualListSelectorComplexOptionsActionsNext: React.FunctionComponent
aria-label="Sort Available"
key="availableSortButton"
isDisabled={isDisabled}
icon={<PficonSortCommonAscIcon />}
icon={<RhMicronsSortDownSmallToLargeIcon />}
/>,
<Dropdown
toggle={(toggleRef: React.Ref<MenuToggleElement>) => (
Expand Down Expand Up @@ -190,7 +190,7 @@ export const DualListSelectorComplexOptionsActionsNext: React.FunctionComponent
aria-label="Sort Chosen"
key="chosenSortButton"
isDisabled={isDisabled}
icon={<PficonSortCommonAscIcon />}
icon={<RhMicronsSortDownSmallToLargeIcon />}
/>,
<Dropdown
toggle={(toggleRef: React.Ref<MenuToggleElement>) => (
Expand Down
2 changes: 1 addition & 1 deletion ...ct-core/src/deprecated/components/DualListSelector/examples/DualListSelector.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ import RhMicronsDoubleCaretLeftIcon from '@patternfly/react-icons/dist/esm/icons
import AngleLeftIcon from '@patternfly/react-icons/dist/esm/icons/angle-left-icon';
import AngleDoubleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-double-right-icon';
import AngleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-right-icon';
import PficonSortCommonAscIcon from '@patternfly/react-icons/dist/esm/icons/pficon-sort-common-asc-icon';
import RhMicronsSortDownSmallToLargeIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-sort-down-small-to-large-icon';
import SearchIcon from '@patternfly/react-icons/dist/esm/icons/search-icon';

## Examples
Expand Down
6 changes: 3 additions & 3 deletions ...deprecated/components/DualListSelector/examples/DualListSelectorComplexOptionsActions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { Fragment, useState } from 'react';
import { Button, ButtonVariant, Checkbox } from '@patternfly/react-core';
import { DualListSelector as DLSDeprecated } from '@patternfly/react-core/deprecated';
import PficonSortCommonAscIcon from '@patternfly/react-icons/dist/esm/icons/pficon-sort-common-asc-icon';
import RhMicronsSortDownSmallToLargeIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-sort-down-small-to-large-icon';

export const DualListSelectorComplexOptionsActions: React.FunctionComponent = () => {
const [availableOptions, setAvailableOptions] = useState<React.ReactNode[]>([
Expand Down Expand Up @@ -47,7 +47,7 @@ export const DualListSelectorComplexOptionsActions: React.FunctionComponent = ()
aria-label="Sort available options"
key="availableSortButton"
isDisabled={isDisabled}
icon={<PficonSortCommonAscIcon />}
icon={<RhMicronsSortDownSmallToLargeIcon />}
/>
];

Expand All @@ -58,7 +58,7 @@ export const DualListSelectorComplexOptionsActions: React.FunctionComponent = ()
aria-label="Sort chosen options"
key="chosenSortButton"
isDisabled={isDisabled}
icon={<PficonSortCommonAscIcon />}
icon={<RhMicronsSortDownSmallToLargeIcon />}
/>
];

Expand Down
4 changes: 2 additions & 2 deletions ...t-core/src/deprecated/components/DualListSelector/examples/DualListSelectorComposable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import RhMicronsDoubleCaretLeftIcon from '@patternfly/react-icons/dist/esm/icons
import AngleLeftIcon from '@patternfly/react-icons/dist/esm/icons/angle-left-icon';
import AngleDoubleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-double-right-icon';
import AngleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-right-icon';
import PficonSortCommonAscIcon from '@patternfly/react-icons/dist/esm/icons/pficon-sort-common-asc-icon';
import RhMicronsSortDownSmallToLargeIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-sort-down-small-to-large-icon';
import SearchIcon from '@patternfly/react-icons/dist/esm/icons/search-icon';

interface Option {
Expand Down Expand Up @@ -137,7 +137,7 @@ export const DualListSelectorComposable: React.FunctionComponent = () => {
onClick={onSort}
aria-label="Sort"
key="sortButton"
icon={<PficonSortCommonAscIcon />}
icon={<RhMicronsSortDownSmallToLargeIcon />}
/>
);
};
Expand Down
1 change: 0 additions & 1 deletion packages/react-drag-drop/src/components/DragDrop/examples/DragDrop.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import RhMicronsDoubleCaretLeftIcon from '@patternfly/react-icons/dist/esm/icons
import AngleLeftIcon from '@patternfly/react-icons/dist/esm/icons/angle-left-icon';
import AngleDoubleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-double-right-icon';
import AngleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-right-icon';
import PficonSortCommonAscIcon from '@patternfly/react-icons/dist/esm/icons/pficon-sort-common-asc-icon';

import { DragDropSort, DragDropContainer, Droppable as NewDroppable } from '@patternfly/react-drag-drop';

Expand Down
1 change: 0 additions & 1 deletion packages/react-drag-drop/src/components/DragDrop/examples/DragDropDemos.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import RhMicronsDoubleCaretLeftIcon from '@patternfly/react-icons/dist/esm/icons
import AngleLeftIcon from '@patternfly/react-icons/dist/esm/icons/angle-left-icon';
import AngleDoubleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-double-right-icon';
import AngleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-right-icon';
import PficonSortCommonAscIcon from '@patternfly/react-icons/dist/esm/icons/pficon-sort-common-asc-icon';

import { DragDropSort, DragDropContainer, Droppable as NewDroppable } from '@patternfly/react-drag-drop';

Expand Down
4 changes: 2 additions & 2 deletions ...demo-app-ts/src/components/demos/DualListSelectorDemo/DualListSelectorWithActionsDemo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ import RhMicronsDoubleCaretLeftIcon from '@patternfly/react-icons/dist/esm/icons
import AngleLeftIcon from '@patternfly/react-icons/dist/esm/icons/angle-left-icon';
import AngleDoubleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-double-right-icon';
import AngleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-right-icon';
import PficonSortCommonAscIcon from '@patternfly/react-icons/dist/esm/icons/pficon-sort-common-asc-icon';
import RhUiSortDownLargeToSmallIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-sort-down-large-to-small-icon';
import RhMicronsSortDownSmallToLargeIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-sort-down-small-to-large-icon';
import SearchIcon from '@patternfly/react-icons/dist/esm/icons/search-icon';
import RhUiEllipsisVerticalFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-ellipsis-vertical-fill-icon';

Expand Down Expand Up @@ -133,7 +133,7 @@ export const DualListSelectorWithActionsDemo: React.FunctionComponent = () => {
return direction === 'asc' ? 'ascending' : 'descending';
},
getIcon(direction: SortDirection) {
return direction === 'asc' ? <PficonSortCommonAscIcon /> : <RhUiSortDownLargeToSmallIcon />;
return direction === 'asc' ? <RhMicronsSortDownSmallToLargeIcon /> : <RhUiSortDownLargeToSmallIcon />;
}
};

Expand Down
6 changes: 3 additions & 3 deletions ...onents/demos/DualListSelectorDeprecatedDemo/DualListSelectorDeprecatedWithActionsDemo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ import {
DualListSelectorProps as DLSPropsDeprecated
} from '@patternfly/react-core/deprecated';
import RhUiSortDownLargeToSmallIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-sort-down-large-to-small-icon';
import PficonSortCommonAscIcon from '@patternfly/react-icons/dist/esm/icons/pficon-sort-common-asc-icon';
import RhUiEllipsisVerticalFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-ellipsis-vertical-fill-icon';
import RhMicronsSortDownSmallToLargeIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-sort-down-small-to-large-icon';

interface DualListSelectorState {
availableOptions: React.ReactNode[];
Expand Down Expand Up @@ -126,7 +126,7 @@ class DualListSelectorDeprecatedWithActionsDemo extends Component<DLSPropsDeprec
onClick={() => this.onSort('available')}
aria-label="Sort"
key="availableSortButton"
icon={this.state.availableDescending ? <RhUiSortDownLargeToSmallIcon /> : <PficonSortCommonAscIcon />}
icon={this.state.availableDescending ? <RhUiSortDownLargeToSmallIcon /> : <RhMicronsSortDownSmallToLargeIcon />}
/>,
<Dropdown
key="availableDropdown"
Expand All @@ -153,7 +153,7 @@ class DualListSelectorDeprecatedWithActionsDemo extends Component<DLSPropsDeprec
onClick={() => this.onSort('chosen')}
aria-label="Sort"
key="chosenSortButton"
icon={this.state.chosenDescending ? <RhUiSortDownLargeToSmallIcon /> : <PficonSortCommonAscIcon />}
icon={this.state.chosenDescending ? <RhUiSortDownLargeToSmallIcon /> : <RhMicronsSortDownSmallToLargeIcon />}
/>,
<Dropdown
isOpen={this.state.isChosenKebabOpen}
Expand Down
Loading