Skip to content

feat(icons): add classes to rh sets#12447

Open
kmcfaul wants to merge 1 commit into
patternfly:mainfrom
kmcfaul:rh-icon-classes
Open

feat(icons): add classes to rh sets#12447
kmcfaul wants to merge 1 commit into
patternfly:mainfrom
kmcfaul:rh-icon-classes

Conversation

@kmcfaul

@kmcfaul kmcfaul commented Jun 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What: Closes #

Adds classes for ui and microns sets.

Summary by CodeRabbit

  • Bug Fixes
    • Red Hat icon components now include proper CSS class names for correct visual styling and theming consistency.

@coderabbitai

coderabbitai Bot commented Jun 11, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

Walkthrough

The PR updates Red Hat icon definitions to include CSS class metadata. The parseRHIcons.mjs script is configured to emit svgClassName values for ui and microns icon types, and all rh-microns-* icons in the exported icon map are updated with the corresponding 'pf-v6-icon-rh-microns' class name.

Changes

RH Icon SVG Class Names

Layer / File(s) Summary
Icon type class mapping
packages/react-icons/scripts/parseRHIcons.mjs		 ICON_TYPE_CLASSES mapping now assigns 'pf-v6-icon-rh-ui' and 'pf-v6-icon-rh-microns' class names for ui and microns icon types (previously empty strings), enabling these class names to be emitted during module generation.
Microns icon exports with class names
packages/react-icons/scripts/icons/rhIconsMicrons.mjs		 All rh-microns-* icon definitions in the exported default icon map now include svgClassName: 'pf-v6-icon-rh-microns' alongside existing offset, sizing, and path data fields.

Possibly related PRs

  • patternfly/patternfly-react#12387: Both PRs modify packages/react-icons/scripts/icons/rhIconsMicrons.mjs microns icon export entries, with direct overlap at the icon-mapping level.
  • patternfly/patternfly-react#12320: Both PRs modify the icon code-generation path to emit svgClassName metadata for RH icon types, consumed by icon class-name composition logic.
  • patternfly/patternfly-react#12245: Updates generated icon metadata to emit svgClassName so subsequent styling and rendering work can apply the expected classes.

Suggested labels

Needs design review

Suggested reviewers

  • nicolethoen
  • thatblindgeye

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding CSS classes to Red Hat icon sets (rh-microns and rh-ui icons).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@patternfly-build

patternfly-build commented Jun 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Preview: https://pf-react-pr-12447.surge.sh

A11y report: https://pf-react-pr-12447-a11y.surge.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kmcfaul @patternfly-build