fix(form): keep required asterisk from orphaning#11961
Merged
Merged
Conversation
Collaborator
|
Preview: https://pf-react-pr-11961.surge.sh A11y report: https://pf-react-pr-11961-a11y.surge.sh |
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Contributor
Author
|
Reviving this old PR. Just replaces the space char between the label and asterisk with a non-breaking space. This is the markup it renders. I'm not sure where the html comment comes from, but it doesn't impact anything. 
Same concept as how it's done in core 
|
thatblindgeye
approved these changes
Nov 12, 2025
srambach
approved these changes
Nov 12, 2025
Member
srambach
left a comment
There was a problem hiding this comment.
Works for me (unless I put a space as the last character of the label 😈 which just don't do that!)
nicolethoen
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #11960