Skip to content

chore(Masthead) fixed docked example logo at mobile#8359

Merged
mcoker merged 1 commit into
patternfly:mainfrom
thatblindgeye:iss8269
May 1, 2026
Merged

chore(Masthead) fixed docked example logo at mobile#8359
mcoker merged 1 commit into
patternfly:mainfrom
thatblindgeye:iss8269

Conversation

@thatblindgeye

@thatblindgeye thatblindgeye commented May 1, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Closes #8269

Summary by CodeRabbit

  • Documentation

    • Updated the docked masthead example to display both compact and non-compact logo variants.

  • Style

    • Updated the masthead logo SVG title label.

@coderabbitai

coderabbitai Bot commented May 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 986acfab-d841-435c-94d2-273ec300bdfb

📥 Commits

Reviewing files that changed from the base of the PR and between 75e0114 and 17634e5.

📒 Files selected for processing (2)
  • src/patternfly/components/Masthead/examples/masthead.md
  • src/patternfly/components/Masthead/masthead-image.hbs

Walkthrough

Adds a full-size masthead logo variant to the Docked example template to fix missing logo visibility on mobile viewports, and updates SVG title accessibility labels from "PF-HorizontalLogo-Color" to "PatternFly" in the masthead logo template.

Changes

Cohort / File(s) Summary
Masthead Example
src/patternfly/components/Masthead/examples/masthead.md		 Added non-compact masthead-logo variant alongside existing compact logo in the Docked example to ensure logo visibility on smaller viewports.
Masthead Template
src/patternfly/components/Masthead/masthead-image.hbs		 Updated SVG <title> accessibility labels in both compact and non-compact masthead logo templates from "PF-HorizontalLogo-Color" to "PatternFly".

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • feat: add dock nav responsive  #8149: Introduces overlapping masthead example and logo rendering changes (adding unconditional non-compact logo alongside conditional compact variant).

Suggested labels

released on @prerelease``

Suggested reviewers

  • kmcfaul
  • mcoker
  • srambach
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title follows conventional commit format (type: scope) description, clearly describing the fix for the docked masthead logo visibility on mobile viewports.
Linked Issues check ✅ Passed The code changes directly address issue #8269 by adding a non-compact masthead logo and updating the SVG title label, resolving the mobile viewport logo visibility problem.
Out of Scope Changes check ✅ Passed All changes are scoped to the docked masthead example and its SVG template; no unrelated modifications or scope creep detected.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@patternfly-build

patternfly-build commented May 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Preview: https://pf-pr-8359.surge.sh

A11y report: https://pf-pr-8359-a11y.surge.sh

@thatblindgeye thatblindgeye requested review from jcmill and mcoker May 1, 2026 13:07
mcoker
mcoker approved these changes May 1, 2026
View reviewed changes

@mcoker mcoker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's Go Team Mates!

@mcoker mcoker merged commit dfd7a90 into patternfly:main May 1, 2026
5 checks passed
@patternfly-build

patternfly-build commented May 5, 2026

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 6.5.0-prerelease.82 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcoker mcoker mcoker approved these changes
@jcmill jcmill Awaiting requested review from jcmill

Assignees

No one assigned

Labels

released on @prerelease

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug - Docked masthead - Example is missing full size logo

3 participants

@thatblindgeye @patternfly-build @mcoker