chore: update backstop screenshots#8337
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (5)
📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughScoped the Compass example CSS height selector to Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error)
✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Collaborator
|
Preview: https://pf-pr-8337.surge.sh A11y report: https://pf-pr-8337-a11y.surge.sh |
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/patternfly/components/Compass/examples/Compass.css (1)
1-3: (Optional) Considermin-heightinstead of fixedheightIf any compass example content can expand vertically, a fixed
height: 600pxmay cause clipping in some contexts (even if it’s fine for screenshot consistency). If the goal is “at least” 600px for visual stability,min-height: 600pxcan reduce risk.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/patternfly/components/Compass/examples/Compass.css` around lines 1 - 3, Replace the fixed height on the selector "#ws-page-main .ws-core-a-compass .pf-v6-c-compass" with a minimum height by changing `height: 600px` to `min-height: 600px` so the compass can grow vertically without clipping while preserving the baseline visual size; update the CSS rule in Compass.css accordingly.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@src/patternfly/components/Compass/examples/Compass.css`:
- Around line 1-3: Replace the fixed height on the selector "#ws-page-main
.ws-core-a-compass .pf-v6-c-compass" with a minimum height by changing `height:
600px` to `min-height: 600px` so the compass can grow vertically without
clipping while preserving the baseline visual size; update the CSS rule in
Compass.css accordingly.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 5b96183c-2ac6-4673-9687-8b1ab95c3e1b
⛔ Files ignored due to path filters (66)
backstop_data/bitmaps_reference/pf-core__ai_generative-uis_compass_html-demos_docked-nav---expanded-on-mobile_0_document_0_mobile.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference/pf-core__ai_generative-uis_compass_html-demos_docked-nav---expanded-on-mobile_0_document_1_tablet.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference/pf-core__ai_generative-uis_compass_html-demos_docked-nav---expanded-on-mobile_0_document_2_desktop.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference/pf-core__ai_generative-uis_compass_html-demos_docked-nav-text-expanded---expanded-on-mobile_0_document_0_mobile.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference/pf-core__ai_generative-uis_compass_html-demos_docked-nav-text-expanded---expanded-on-mobile_0_document_1_tablet.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference/pf-core__ai_generative-uis_compass_html-demos_docked-nav-text-expanded---expanded-on-mobile_0_document_2_desktop.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference/pf-core__ai_generative-uis_compass_html-demos_docked-nav-text-expanded_0_document_0_mobile.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference/pf-core__ai_generative-uis_compass_html-demos_docked-nav-text-expanded_0_document_1_tablet.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference/pf-core__ai_generative-uis_compass_html-demos_docked-nav-text-expanded_0_document_2_desktop.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference/pf-core__ai_generative-uis_compass_html-demos_docked-nav_0_document_0_mobile.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference/pf-core__ai_generative-uis_compass_html-demos_docked-nav_0_document_1_tablet.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference/pf-core__ai_generative-uis_compass_html-demos_docked-nav_0_document_2_desktop.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference/pf-core__ai_generative-uis_compass_html_basic_0_document_0_mobile.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference/pf-core__ai_generative-uis_compass_html_basic_0_document_1_tablet.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference/pf-core__ai_generative-uis_compass_html_basic_0_document_2_desktop.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference/pf-core__ai_generative-uis_compass_html_docked_0_document_0_mobile.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference/pf-core__ai_generative-uis_compass_html_docked_0_document_1_tablet.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference/pf-core__ai_generative-uis_compass_html_docked_0_document_2_desktop.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference/pf-core__components_button_html_stateful_0_document_0_mobile.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference/pf-core__components_button_html_stateful_0_document_1_tablet.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference/pf-core__components_button_html_stateful_0_document_2_desktop.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference/pf-core__components_toggle-group_html_compact_0_document_0_mobile.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference/pf-core__components_toggle-group_html_compact_0_document_1_tablet.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference/pf-core__components_toggle-group_html_compact_0_document_2_desktop.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference/pf-core__components_toggle-group_html_full-width-toggle_0_document_0_mobile.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference/pf-core__components_toggle-group_html_full-width-toggle_0_document_1_tablet.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference/pf-core__components_toggle-group_html_full-width-toggle_0_document_2_desktop.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference/pf-core__components_toolbar_html_dynamic-sticky-toolbar_0_document_0_mobile.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference/pf-core__components_toolbar_html_dynamic-sticky-toolbar_0_document_1_tablet.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference/pf-core__components_toolbar_html_dynamic-sticky-toolbar_0_document_2_desktop.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference_glass/pf-core__ai_generative-uis_compass_html-demos_docked-nav---expanded-on-mobile_0_document_0_mobile.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference_glass/pf-core__ai_generative-uis_compass_html-demos_docked-nav---expanded-on-mobile_0_document_1_tablet.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference_glass/pf-core__ai_generative-uis_compass_html-demos_docked-nav---expanded-on-mobile_0_document_2_desktop.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference_glass/pf-core__ai_generative-uis_compass_html-demos_docked-nav-text-expanded---expanded-on-mobile_0_document_0_mobile.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference_glass/pf-core__ai_generative-uis_compass_html-demos_docked-nav-text-expanded---expanded-on-mobile_0_document_1_tablet.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference_glass/pf-core__ai_generative-uis_compass_html-demos_docked-nav-text-expanded---expanded-on-mobile_0_document_2_desktop.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference_glass/pf-core__ai_generative-uis_compass_html-demos_docked-nav-text-expanded_0_document_0_mobile.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference_glass/pf-core__ai_generative-uis_compass_html-demos_docked-nav-text-expanded_0_document_1_tablet.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference_glass/pf-core__ai_generative-uis_compass_html-demos_docked-nav-text-expanded_0_document_2_desktop.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference_glass/pf-core__ai_generative-uis_compass_html-demos_docked-nav_0_document_0_mobile.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference_glass/pf-core__ai_generative-uis_compass_html-demos_docked-nav_0_document_1_tablet.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference_glass/pf-core__ai_generative-uis_compass_html-demos_docked-nav_0_document_2_desktop.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference_glass/pf-core__ai_generative-uis_compass_html_basic_0_document_0_mobile.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference_glass/pf-core__ai_generative-uis_compass_html_basic_0_document_1_tablet.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference_glass/pf-core__ai_generative-uis_compass_html_basic_0_document_2_desktop.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference_glass/pf-core__ai_generative-uis_compass_html_docked_0_document_0_mobile.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference_glass/pf-core__ai_generative-uis_compass_html_docked_0_document_1_tablet.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference_glass/pf-core__ai_generative-uis_compass_html_docked_0_document_2_desktop.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference_glass/pf-core__components_button_html_stateful_0_document_0_mobile.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference_glass/pf-core__components_button_html_stateful_0_document_1_tablet.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference_glass/pf-core__components_button_html_stateful_0_document_2_desktop.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference_glass/pf-core__components_table_html-demos_sticky-header-and-last-column_0_document_0_mobile.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference_glass/pf-core__components_table_html-demos_sticky-header-and-last-column_0_document_1_tablet.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference_glass/pf-core__components_table_html-demos_sticky-header-and-last-column_0_document_2_desktop.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference_glass/pf-core__components_table_html_sticky-right-column_0_document_0_mobile.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference_glass/pf-core__components_table_html_sticky-right-column_0_document_1_tablet.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference_glass/pf-core__components_table_html_sticky-right-column_0_document_2_desktop.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference_glass/pf-core__components_toggle-group_html_compact_0_document_0_mobile.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference_glass/pf-core__components_toggle-group_html_compact_0_document_1_tablet.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference_glass/pf-core__components_toggle-group_html_compact_0_document_2_desktop.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference_glass/pf-core__components_toggle-group_html_full-width-toggle_0_document_0_mobile.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference_glass/pf-core__components_toggle-group_html_full-width-toggle_0_document_1_tablet.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference_glass/pf-core__components_toggle-group_html_full-width-toggle_0_document_2_desktop.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference_glass/pf-core__components_toolbar_html_dynamic-sticky-toolbar_0_document_0_mobile.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference_glass/pf-core__components_toolbar_html_dynamic-sticky-toolbar_0_document_1_tablet.pngis excluded by!**/*.pngbackstop_data/bitmaps_reference_glass/pf-core__components_toolbar_html_dynamic-sticky-toolbar_0_document_2_desktop.pngis excluded by!**/*.png
📒 Files selected for processing (1)
src/patternfly/components/Compass/examples/Compass.css
Collaborator
|
🎉 This PR is included in version 6.5.0-prerelease.79 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failure report. This is glass, but it shows all of the failures from non-glass + glass dock styles.
All failures look expected to me
backstop-4.27.26.pdf
Summary by CodeRabbit