Skip to content

chore(Dock): updated dock classes to docked#8308

Merged
mcoker merged 1 commit into
patternfly:mainfrom
thatblindgeye:changeDockToDocked
Apr 15, 2026
Merged

chore(Dock): updated dock classes to docked#8308
mcoker merged 1 commit into
patternfly:mainfrom
thatblindgeye:changeDockToDocked

Conversation

@thatblindgeye

@thatblindgeye thatblindgeye commented Apr 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Closes #8309

Summary by CodeRabbit

  • Style

    • Standardized CSS modifier class naming across Button, Compass, MenuToggle, and Page components for consistency.

  • Documentation

    • Updated component documentation to reflect new modifier class naming conventions.

@coderabbitai

coderabbitai Bot commented Apr 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 06bbf43f-5ac0-4e4c-910e-976af56471c0

📥 Commits

Reviewing files that changed from the base of the PR and between 8e414b8 and c4286fe.

📒 Files selected for processing (11)
  • src/patternfly/components/Button/button.hbs
  • src/patternfly/components/Button/button.scss
  • src/patternfly/components/Compass/compass.hbs
  • src/patternfly/components/Compass/compass.scss
  • src/patternfly/components/Compass/examples/Compass.md
  • src/patternfly/components/MenuToggle/menu-toggle.hbs
  • src/patternfly/components/MenuToggle/menu-toggle.scss
  • src/patternfly/components/Page/examples/Page.md
  • src/patternfly/components/Page/page.hbs
  • src/patternfly/components/Page/page.scss
  • src/patternfly/demos/Masthead/masthead-template-content-toolbar-content.hbs

Walkthrough

This PR renames dock-related CSS modifiers and template flags across multiple PatternFly components from pf-m-dock/IsDock to pf-m-docked/IsDocked, updating template bindings, stylesheet selectors, and documentation consistently throughout the codebase.

Changes

Cohort / File(s) Summary
Button Component
src/patternfly/components/Button/button.hbs, src/patternfly/components/Button/button.scss		 Renamed dock modifier from pf-m-dock to pf-m-docked and template property from button--IsDock to button--IsDocked.
Compass Component
src/patternfly/components/Compass/compass.hbs, src/patternfly/components/Compass/compass.scss, src/patternfly/components/Compass/examples/Compass.md		 Updated Compass dock modifier from pf-m-dock to pf-m-docked across template binding, stylesheet selector, and documentation references.
MenuToggle Component
src/patternfly/components/MenuToggle/menu-toggle.hbs, src/patternfly/components/MenuToggle/menu-toggle.scss		 Renamed dock modifier from pf-m-dock to pf-m-docked and updated all template conditionals from menu-toggle--IsDock to menu-toggle--IsDocked.
Page Component
src/patternfly/components/Page/page.hbs, src/patternfly/components/Page/page.scss, src/patternfly/components/Page/examples/Page.md		 Updated Page dock modifier from pf-m-dock to pf-m-docked in template binding, two stylesheet selector locations, and documentation.
Masthead Demo
src/patternfly/demos/Masthead/masthead-template-content-toolbar-content.hbs		 Updated masthead demo toolbar action items to use renamed --IsDocked flag instead of --IsDock for menu-toggle and button components.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Suggested reviewers

  • kmcfaul
  • mcoker
  • srambach
  • lboehling
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title follows conventional commit format with type 'chore' and scope 'Dock', and accurately reflects the main change of renaming dock-related CSS modifier classes from 'pf-m-dock' to 'pf-m-docked' across multiple components.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@thatblindgeye thatblindgeye requested a review from mcoker April 14, 2026 12:26
@patternfly-build

patternfly-build commented Apr 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Preview: https://pf-pr-8308.surge.sh

A11y report: https://pf-pr-8308-a11y.surge.sh

mcoker
mcoker approved these changes Apr 15, 2026
View reviewed changes

@mcoker mcoker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪄

@mcoker mcoker merged commit 3fb77df into patternfly:main Apr 15, 2026
5 checks passed
@coderabbitai coderabbitai Bot mentioned this pull request Apr 15, 2026
Merged
@thatblindgeye thatblindgeye deleted the changeDockToDocked branch April 15, 2026 12:02
@patternfly-build

patternfly-build commented Apr 15, 2026

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 6.5.0-prerelease.70 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Apr 24, 2026
Merged
Closed
Merged
This was referenced May 8, 2026
Merged
Closed
@coderabbitai coderabbitai Bot mentioned this pull request May 26, 2026
Merged
@coderabbitai coderabbitai Bot mentioned this pull request Jun 23, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcoker mcoker mcoker approved these changes

Assignees

No one assigned

Labels

released on @prerelease

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update pf-m-dock to pf-m-docked

3 participants

@thatblindgeye @patternfly-build @mcoker