pycodestyle config: convert arrays to comma seperated strings#164
Merged
Conversation
Contributor
|
Thanks for this! Is there a separate ticket open for the other issue? I can look into some time this week probably |
Contributor
Author
Thanks a lot, that would be great 👍
I opened #165 which adds a failing test case to illustrate the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #156 (comment) since pycodestyle expects the config values as a comma separated string.
Unfortunately ignoring a specific error code still doesn't work correctly, all errors are ignored instead. The same happens for warnings too. Any idea why this is happening?
Fixes #156