Skip to content

Added propagation control functions and fix implicit string conversion in headers. #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rayment wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Added propagation control functions and fix implicit string conversion in headers. #367

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3e99eb3
Added propagation control functions.
rayment Jan 28, 2023
41957ea
Fixed unused variable.
rayment Jan 28, 2023
7f9d7ab
Wrapped header string constants in QLatin1String(...).
rayment Jan 29, 2023
bb42e8f
Changed propagation functions to protected virtual.
rayment Jan 29, 2023
1531218
Formatted changes with clang-format.
rayment Jan 31, 2023
bbd92b7
Merge branch 'master' into data-propagation
rayment Jan 31, 2023
0bdbd77
Made canPropagate a const method.
rayment Jul 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Changed propagation functions to protected virtual. 
Signed-off-by: Finn Rayment <finn@rayment.fr>
  • Loading branch information
@rayment
rayment committed Jan 29, 2023
commit bb42e8f488fa261b1ad0ed997866135e072d0e82
6 changes: 3 additions & 3 deletions include/QtNodes/internal/DataFlowGraphModel.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ public Q_SLOTS:
private:
NodeId newNodeId() override { return _nextNodeId++; }

private Q_SLOTS:
protected Q_SLOTS:
/**
* Fuction is called in three cases:
*
Expand All @@ -117,10 +117,10 @@ private Q_SLOTS:
* - When a node restored from JSON an needs to send data downstream.
* @see DataFlowGraphModel::loadNode
*/
void onOutPortDataUpdated(NodeId const nodeId, PortIndex const portIndex);
virtual void onOutPortDataUpdated(NodeId const nodeId, PortIndex const portIndex);

/// Function is called after detaching a connection.
void propagateEmptyDataTo(NodeId const nodeId, PortIndex const portIndex);
virtual void propagateEmptyDataTo(NodeId const nodeId, PortIndex const portIndex);

private:
std::shared_ptr<NodeDelegateModelRegistry> _registry;
Expand Down