Handle rename of net.Server.prototype._listen2#103
Merged
watson merged 1 commit intoothiym23:masterfrom Dec 21, 2017
Merged
Conversation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In nodejs/node#11796 the
net.Server.prototype._listen2function is being renamed to_setUpListenHandle.The function is still aliased as
_listen2, and currently the Node internals still call the alias - but who knows for how long. So better make sure we use the new name instead if available.This have not yet shipped, so maybe this PR is a little early. But I thought I'd better get it in so we don't forget. We can leave this PR open and track the progress before merging maybe?