Add sql_type column field in flex output#1510
Merged
lonvia merged 1 commit intoosm2pgsql-dev:masterfrom May 27, 2021
Merged
Conversation
The "type" field in a flex output column definition really does two things: 1. It defines the way Lua values are transformed into PostgreSQL values. 2. It defines which PostgreSQL type should be used in a the CREATE TABLE statement for a particular column. This commit adds a new "sql_type" field which takes over the second meaning. If it is not specified, the default is still defined by the "type" field. The default for the type field is "text". The result is that in most cases you use only the "type" field as before and it does the right thing. If you need a special SQL type, use the "sql_type" field instead or in addition to the "type" field. Note that this is a breaking change, but still allowed because the flex output is still marked experimental.
|
Looks like a useful addition |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "type" field in a flex output column definition really does two
things:
values.
TABLE statement for a particular column.
This commit adds a new "sql_type" field which takes over the second
meaning. If it is not specified, the default is still defined by
the "type" field. The default for the type field is "text".
The result is that in most cases you use only the "type" field as before
and it does the right thing. If you need a special SQL type, use the
"sql_type" field instead or in addition to the "type" field.
Note that this is a breaking change, but still allowed because the flex
output is still marked experimental.