Conversation
Updates ASM to 9.8 to be in sync with `mx-suite` and `graalvm-community-jdk25u` repositories regarding ASM version. Notice, the latest ASM version is 9.9.1 that supports Java 26, but this PR syncs ASM to 9.8 for consistency with [mx suite](https://github.com/graalvm/mx/blob/6934051ffc792c8f5b9a6fd35aeb3e257ad67a3f/mx.mx/suite.py#L46-L91). Previous issue (fixed in graalvm-community-jdk25u) oracle#12723 Signed-off-by: Oleksandr Porunov <alexandr.porunov@gmail.com>
|
Thank you for your contribution, we'll take a look at this shortly @wirthi could you please assign the appropriate person to review? thank you |
| "class" : "ShadedLibraryProject", | ||
| "shade" : { | ||
| "packages" : { | ||
| "org.objectweb.asm" : "com.oracle.truffle.espresso.shadowed.asm", |
There was a problem hiding this comment.
I think this code needs to be updated, as we shadow that library there. I don't think this happend as part of your PR?
There was a problem hiding this comment.
@wirthi I'm not sure what parts of the code should be updated. As far as I know ASM 9.8 didn't have any breaking changes, so I doubt there would be necessity to update particular code, but I might just miss something that's not obvious to me.
From ASM changelog:
29 March 2025: ASM 9.8 (tag ASM_9_8)
new Opcodes.V25 constant for Java 25 bug fixes Fix one more copy operation on DUP2 318015: Valid bytecode for jvm, but failed to pass the CheckClassAdapter. `ASMifier` should print calls to `valueOf` instead of deprecated constructors of primitive wrappers
Do you think there could be some places where these fixes were previously patched and I need to remove those patches or you refer to some other changes that should be done during version updates of shadowed libraries?
There was a problem hiding this comment.
@gilles-duboscq is this update of the dependency alone enough to update the shadowed library? Or does @porunov need to update any code in the repo for this?
There was a problem hiding this comment.
I think the update to the library alone should be enough.
There was a problem hiding this comment.
@wirthi let me know please if there are any other changes needed in this PR or if the current changes are sufficient. Thank you!
There was a problem hiding this comment.
@wirthi I just wander if you had a chance to take another look into this PR. Do you see any obstacles or issues that could prevent this PR from being merged? Happy to resolve those if there are any. Thank you.
There was a problem hiding this comment.
sorry for the delay. I'll put the PR in our internal CI, will also require internal approvals.
I am on it.
There was a problem hiding this comment.
Thank you! Let me know if any changes are needed from my side and I will try to resolve them if there are any.
Updates ASM to 9.8 to be in sync with
mx-suiteandgraalvm-community-jdk25urepositories regarding ASM version.Notice, the latest ASM version is 9.9.1 that supports Java 26, but this PR syncs ASM to 9.8 for consistency with mx suite.
This PR is the same as in previously closed PR #12965 but no longer related to previous issue #12723 which was fixed in
graalvm-community-jdk25u.The only purpose of this PR is to keep versions in sync between repositories, but not particular functionality issues.
If there are any reasons to keep ASM 9.7.1 in
oracle/graalrepository - let me know and we can close this PR in this case.