Skip to content

chore: update tests because of custom json encoder#407

Merged
Mat001 merged 2 commits into
masterfrom
mpirnovar/update_zaius_rest_api_tests
Sep 26, 2022
Merged

chore: update tests because of custom json encoder#407
Mat001 merged 2 commits into
masterfrom
mpirnovar/update_zaius_rest_api_tests

Conversation

@Mat001
Copy link
Copy Markdown
Contributor

@Mat001 Mat001 commented Sep 26, 2022

Summary

  • An addition of custom JSON encoder in OdpEvent and ZaiusRestApiManager required the ZaiusrestApi tests to be updated.
  • Changed event payload from dicts to instances of OdpEvent class.
  • One test needed to be updated.

Test plan

  • passing unit tests

Issues

Copy link
Copy Markdown
Contributor

@andrewleap-optimizely andrewleap-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mat001 Mat001 merged commit 082f171 into master Sep 26, 2022
@Mat001 Mat001 deleted the mpirnovar/update_zaius_rest_api_tests branch September 26, 2022 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants